I'm looking for a part-time remote job.

Hire me


I'm the author of:

Mastering Redmine is a comprehensive guide with tips, tricks and best practices, and an easy-to-learn structure.

Check the book's project or

Buy the book

Social pages of the book:

By buying this book you also donate to Redmine (see this page).


Follow me:

Feature #1760

Make SCM optional even with auto_create

Added by Jean-Sébastien Bour over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
30 May 2011
Due date:
01 Jun 2011
% Done:

100%

External issue:

Description

We use Redmine for projects which don’t really have source code; I don’t think repository creation should be forced with auto_create.
I attach a really ugly patch just for the PoC of what I think should be done. Ugly because there’s some business logic in a view, which should probably go into a controller helper like the repository helper, and I hacked the project class patch just to “make it work” although I don’t really looked for what a safe_attributes is (and maybe the after_create should be filtered with a “if @scm” ?)

make_scm_optionnal_even_with_autocreate.patch View (1.65 KB) Jean-Sébastien Bour, 30 May 2011 13:43

History

#1 Updated by Andriy Lesyuk over 13 years ago

  • Status changed from New to Open
  • Assignee set to Andriy Lesyuk
  • Target version set to 0.1.0

Yeah! You are right! auto_create should not mean “force”... Thanks for suggestion!..

I think I will may be add possible values to auto_create like: true, false or force (meaning true but require SCM)...

#2 Updated by Andriy Lesyuk over 13 years ago

  • Subject changed from Make SCM optionnal even with autocreate to Make SCM optional even with auto_create
  • Due date set to 01 Jun 2011
  • Status changed from Open to Closed
  • % Done changed from 0 to 100

I believe I have fixed it!

Also available in: Atom PDF

Terms of use | Privacy policy