Redmine › Download Button

Wow, I actually didn’t notice this issue before... I just implemented this and wanted to share the patch with you.

The implementation for Redmine was actually quickly done, but the new Liquid layer in ChiliProject 3.0 gave me some troubles. However, here it is.

Use in Redmine/ChiliProject < 3.0 as follows: {{download_button}}
Use in ChiliProject >= 3.0 as follows: {% download_button %}

Additionally, each of these macros/tags can have additional attributes to slightly change the style and/or the attributes of the DownloadButton.

For example,

Redmine/ChiliProject 2.x

{{download_button(package=nifticlib, label=Get the NIfTI library for C!, include_version=false, width=200px, font_size=20px)}}
{{download_button(float=left, margin_right=10px)}}

ChiliProject 3.x:

{% download_button package=nifticlib, label=Get the NIfTI library for C!, include_version=false, width=200px, font_size=20px %}
{% download_button float=left, margin_right=10px %}

You may consider renaming this macro/tag to !{{download}} if you prefer. I was just thinking download_button clarifies that the macro/tag will only place a button there, but not perform a download action... on the other side, the name of the plugin is download. The decision is up to you.

BTW This macro/tag works also great with your sidebar content plugin. This way it is even better configurable for which views to render the download button in the sidebar. Further it can be accompanied by additional text/graphics...

Here is a clean version of the patch with all unnecessary changes reverted which I made while I was trying to get the Liquid tag for ChiliProject 3.0 working... further, I reverted the bump of the version number here as well.

Of course I yet found some bugs in the parsing of the macro arguments (shouldn’t have just copied the function from Redmine). Played more with it now and am satisfied so far. I renamed the macro to !{{download}}, respectively, {% download %} now, by the way.

I just noticed a minor mistake in the patch. I forgot to remove the obsolete code from DownloadMacroHelper#extract_download_options() which has been moved to DownloadMacroHelper#to_container_style() and DownloadMacroHelper#to_button_style(), respectively.

So here’s the once more modified patch...