I'm looking for a part-time remote job.

Hire me


I'm the author of:

Mastering Redmine is a comprehensive guide with tips, tricks and best practices, and an easy-to-learn structure.

Check the book's project or

Buy the book

Social pages of the book:

By buying this book you also donate to Redmine (see this page).


Follow me:

Support #1886

Going to make hooks obsolete... Should I?

Added by Andriy Lesyuk over 12 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
-
Start date:
01 Nov 2011
Due date:
06 May 2014
% Done:

100%

Redmine version:
External issue:

Description

The hooks option suggested by Takashi Okamoto (thanks, Takashi!) is really cool but... When added this feature I thought that maybe it’s not a good idea to copy files inside Ruby process. For copying files Ruby also runs shell... At that time I decided to think about a better implementation meanwhile including hooks...

Now seems a better idea was suggested by Blaž Podržaj. I believe it’s better to use the on creation script to copy hooks! So after adding these scripts I’m going to make hooks/hgrc options obsolete and remove them in future versions!

What do you think?


Related issues

Related to SCM Creator (+Github) - Feature #1870: Adding creation and deletion external script option Closed 14 Oct 2011 05 Nov 2011

Associated revisions

Revision 120 (diff)
Added by Andriy Lesyuk over 11 years ago

Added support for jQuery/Redmine 2.1.x (#2101), disabled hooks option (#1886)

Revision 132 (diff)
Added by Andriy Lesyuk almost 10 years ago

GithubCreator support (#1950), SCMCreator interface fixes, hooks removal (#1886)

History

#1 Updated by Andriy Lesyuk over 12 years ago

Check this article on how to migrate: Migrating from hooks to scripts

#2 Updated by Blaž Podržaj over 12 years ago

So to clear things up... you export 3 variables right? And $3 is actually a project identifier? I’m asking becaus I’m working on a script that will generate hooks on-the-fly and project identifier needs to be part of those hooks. The idea is to optimize post-commit to only fetch changesets from their project repo.

#3 Updated by Blaž Podržaj over 12 years ago

Ahh, I have just seen Scripts. Please disregard my previous comment.

#4 Updated by Andriy Lesyuk over 11 years ago

  • Target version set to 0.4.2

#5 Updated by Andriy Lesyuk over 11 years ago

  • Status changed from Open to In Progress
  • Assignee set to Andriy Lesyuk
  • Target version deleted (0.4.2)
  • % Done changed from 0 to 80

Will need to remove the option, perhaps...

#6 Updated by Andriy Lesyuk almost 10 years ago

  • Due date set to 06 May 2014
  • Status changed from In Progress to Closed
  • % Done changed from 80 to 100

Also available in: Atom PDF

Terms of use | Privacy policy