I'm looking for a part-time remote job.

Hire me


I'm the author of:

Mastering Redmine is a comprehensive guide with tips, tricks and best practices, and an easy-to-learn structure.

Check the book's project or

Buy the book

Social pages of the book:

By buying this book you also donate to Redmine (see this page).


Follow me:

Feature #1895

Do not auto create repo if Repository module is not enabled

Added by Blaž Podržaj over 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
24 Nov 2011
Due date:
29 May 2012
% Done:

100%

External issue:

Description

Another suggestion from my end that I think would be great. What I use now is auto_create: force since I only use SVN as a repo type. In this case repo is created even if Repository module is not enabled on project creation. I think a condition to auto create a repo only if Repository module is enabled would be OK. What do you think?

SCMCreator-1895.patch View (1.48 KB) Andriy Lesyuk, 26 May 2012 10:51

Associated revisions

Revision 84 (diff)
Added by Andriy Lesyuk almost 12 years ago

Not creating repository if Repository module is disabled (#1895)

Revision 85 (diff)
Added by Andriy Lesyuk almost 12 years ago

Moved :view_projects_form content to views, hiding SCM when Repository is not checked (fixes #1895)

History

#1 Updated by Blaž Podržaj over 12 years ago

I would also suggest for project creation page in case of auto_create: true to show SCM drop-down only if Repository module is selected. Otherwise it could be hidden.

#2 Updated by Andriy Lesyuk over 12 years ago

  • Status changed from New to Open

Agreed!

#3 Updated by Andriy Lesyuk almost 12 years ago

Thought a little bit more about the issue... auto_create: force is designed to force creation of repositories for all projects! That is in this case it’s better to auto check “Repository” module. If one wants repositories to be optional he/she should use auto_create: true instead...

What do you think?

P.S. Attached patch for making what you want...

#4 Updated by Andriy Lesyuk almost 12 years ago

  • % Done changed from 20 to 50

Did as you requested... Changed my mind! I think you were right.

The only issue regarding this is that if you select SCM and uncheck Repository the repository will be not created silently...

#5 Updated by Andriy Lesyuk almost 12 years ago

  • Due date set to 29 May 2012
  • Status changed from In Progress to Closed
  • % Done changed from 50 to 100

Hiding “SCM” if Repository module is not checked. Thanks Blaž!

Also available in: Atom PDF

Terms of use | Privacy policy