I'm looking for a part-time remote job.

Hire me


I'm the author of:

Mastering Redmine is a comprehensive guide with tips, tricks and best practices, and an easy-to-learn structure.

Check the book's project or

Buy the book

Social pages of the book:

By buying this book you also donate to Redmine (see this page).


Follow me:

Patch #2024

Associate existing accounts by email

Added by Ruben Silva over 7 years ago. Updated over 5 years ago.

Status:
Under Verification
Priority:
Normal
Assignee:
Start date:
18 Apr 2012
Due date:
% Done:

0%

Redmine version:
External issue:

Description

Hi there, I was struggling with OpenId account association until I realize that is just not implemented at all. So after this: http://stackoverflow.com/questions/8806865/redmine-openid-usage where @mppfiles bring openId fix to my knowledge I went a little deeper I edit the code so now it checks if the email returned by openID is an existing user email and if so associates the identity_url permanently.

Patch attached.

openid_account_controller_patch.rb.patch View (1.12 KB) Ruben Silva, 18 Apr 2012 10:05

openid_account_controller_patch.rb View (6.73 KB) Leonid Titov, 11 Jul 2013 09:04

openid_account_controller_patch.rb View (4.87 KB) Dmitry Chernov, 12 Jul 2013 09:54

History

#1 Updated by Andriy Lesyuk almost 7 years ago

  • Status changed from New to Incomplete
  • Assignee set to Andriy Lesyuk

Thanks for patch! Can’t currently decide if it should be merged in...

#2 Updated by Leonid Titov over 6 years ago

Hello Andriy! Thanks a lot for your redmine activity!

I have a question about this issue.

Now I use 0.1.0 version of this plugin, and - as I can see - you have slightly modified the code, so above patch is not applicable directly.

I tried to modify current code by myself, but have no success - I’m not a ruby developer at all

You can see my version of the code in attachement.

Here is production.log for a login attempt:

@ArgumentError (http://axschema.org/contact/email is not a defined simple registration field):
  lib/plugins/open_id_authentication/lib/open_id_authentication.rb:145:in `complete_open_id_authentication'
  lib/plugins/open_id_authentication/lib/open_id_authentication.rb:121:in `authenticate_with_open_id'
  app/controllers/account_controller.rb:159:in `authenticate_user'
  app/controllers/account_controller.rb:32:in `login'@

So how can I implement this feature and allow existing users login with openid, recognizing them by their email?

#3 Updated by Dmitry Chernov over 6 years ago

I fixed this issue.]
A working version is attached

#4 Updated by Andriy Lesyuk over 5 years ago

  • Status changed from Incomplete to Under Verification

Also available in: Atom PDF

Terms of use | Privacy policy