I'm looking for a part-time remote job.

Hire me


I'm the author of:

Mastering Redmine is a comprehensive guide with tips, tricks and best practices, and an easy-to-learn structure.

Check the book's project or

Buy the book

Social pages of the book:

By buying this book you also donate to Redmine (see this page).


Follow me:

Bug #2120

git_ext not applied when creating repository after project creation

Added by Christian Rishøj about 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
08 Nov 2012
Due date:
% Done:

0%

Redmine version:
External issue:

Description

The git_ext option adds a default extension to git repositories, and it works well when creating a new project and auto-creating a repository in the process.

However, when creating the repository after the project has been created, the git_ext option has no effect.

Here’s a small patch that fixes the issue:

--- vendor/plugins/redmine_scm/lib/scm_repositories_controller_patch.rb.orig    2012-11-08 13:31:43.000000000 +0800
+++ vendor/plugins/redmine_scm/lib/scm_repositories_controller_patch.rb    2012-11-08 13:32:02.000000000 +0800
@@ -220,7 +220,7 @@
         def scm_create_repository(repository, interface, url)
             name = interface.repository_name(url)
             if name
-                path = interface.path(name)
+                path = interface.default_path(name)
                 if File.directory?(path)
                     repository.errors.add(:url, :already_exists)
                 else


Related issues

Duplicates SCM Creator (+Github) - Patch #2095: Git repositories are always created without .git extension Closed 24 Jul 2012 14 Nov 2012

Associated revisions

Revision 119 (diff)
Added by Andriy Lesyuk about 12 years ago

Applied fixes (#2095, #2102 and #2120)

History

#1 Updated by Andriy Lesyuk about 12 years ago

  • Status changed from New to Open
  • Target version set to 0.4.2

#2 Updated by Andriy Lesyuk about 12 years ago

  • Status changed from Open to Closed

Also available in: Atom PDF

Terms of use | Privacy policy