Bug #2295
view_layouts_base_html_head hook not working
Start date:
24 May 2014
Due date:
11 Jun 2014
% Done:
90%
Redmine version:
2.5.1
External issue:
Description
Hello,
It appears the view_layouts_base_html_head hook isn’t working, because it’s already used by the Hook Manager plugin itself to register its stylesheet.
See the attached patch for a simple fix (tested against Hook Manager 1.0.0 running on Redmine 2.5.1).
Thanks for making this plugin.
Associated revisions
Fixed #2295 (thanks Fabien Crespel) and plugin path
History
#1
Updated by Andriy Lesyuk over 9 years ago
Updated by - Status changed from New to Open
- Target version set to 1.0.1
#2
Updated by Andriy Lesyuk over 9 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
#3
Updated by Andriy Lesyuk over 9 years ago
- Due date set to 11 Jun 2014
#4
Updated by Fabien Crespel over 9 years ago
Updated by - File hooks_manager_hook.rb.patch View added
- Status changed from Closed to Reopened
- Target version deleted (
1.0.1) - % Done changed from 100 to 90
Thanks for taking this bug into account and for fixing the plugin stylesheet issue.
However there is still an issue in version 1.0.1: the hook HTML code is automatically escaped, which makes it pretty useless in the head block.
Attached is a patch against 1.0.1 to mark the view_layouts_base_html_head hook HTML code as safe.