I'm looking for a part-time remote job.

Hire me


I'm the author of:

Mastering Redmine is a comprehensive guide with tips, tricks and best practices, and an easy-to-learn structure.

Check the book's project or

Buy the book

Social pages of the book:

By buying this book you also donate to Redmine (see this page).


Follow me:

Patch #2290

Various improvements to plugin

Added by Elektritter Messinger over 5 years ago. Updated almost 3 years ago.

Status:
Under Verification
Priority:
Normal
Assignee:
Target version:
Start date:
06 May 2014
Due date:
% Done:

70%

Redmine version:
External issue:

Description

Hi, I did some improvements to this plugin which make handling for enduser a lot better I think and are in use in our installations.

In result this are 10 patches, I just append them here. Numbering is in order of apply (patch -p 1 < filename.patch)

Inside each patch is the commit description what this patch does:

  1. hide the new repository button when it is disabled
  2. the button “create repository” is displayed only once and below the form as all other buttons, too.
  3. removed the login inputs for subversion repository 'cause them only are created local
  4. set extension ".git” for new git repositories if extension is enabled
  5. display orginal svn form if subversion creator isn’t enabled. Belongs to patch 3
  6. a better default repository name for git creator
  7. some improvements to the creation and add button
  8. remove create button from inside form, belongs to some patches before
  9. Special repository name input if allow_add_local == false. This means, it has now a more intelligent mask so no wrong repository names could entered
  10. display the clone/checkout url in top of a repository view so user without access to settings page can copy it easly

Hope, this patches helps you and your nice plugin.

0001-Hide-new-repository-button-when-disabled.patch View (1.08 KB) Elektritter Messinger, 06 May 2014 12:12

0002-Create-Repository-button-below-formular-and-only-onc.patch View (3.18 KB) Elektritter Messinger, 06 May 2014 12:12

0003-Remove-login-inputs-from-svn-repository-form-plugin-.patch View (2.18 KB) Elektritter Messinger, 06 May 2014 12:12

0004-GIT-URLs-may-have-the-extension-.git-when.patch View (914 Bytes) Elektritter Messinger, 06 May 2014 12:12

0005-Show-original-svn-form-if-SubversionCreator-isn-t-en.patch View (972 Bytes) Elektritter Messinger, 06 May 2014 12:12

0006-Better-default-repository-name-for-GitCreator.patch View (1.45 KB) Elektritter Messinger, 06 May 2014 12:12

0007-display-creation-button-below-form.patch View (4.38 KB) Elektritter Messinger, 06 May 2014 12:12

0008-removed-create-repository-button-from-inside-form-it.patch View (3.79 KB) Elektritter Messinger, 06 May 2014 12:12

0009-Special-repository-name-input-if-allow_add_local-fal.patch View (11.2 KB) Elektritter Messinger, 06 May 2014 12:12

0010-Use-repository-detail-view-hook-for-displaying-the-u.patch View (2.77 KB) Elektritter Messinger, 06 May 2014 12:12

0013-Fix-a-problem-with-creating-svn-repositories-url.patch View (2.51 KB) Elektritter Messinger, 08 May 2014 12:27


Related issues

Related to SCM Creator (+Github) - Bug #2238: "Create new repository"-Button is shown twice Closed 27 Sep 2013 11 May 2014

Associated revisions

Revision 136 (diff)
Added by Andriy Lesyuk over 5 years ago

Updated patched views, fixed substitution (#2238), hiding login/password (#2290)

Revision 137 (diff)
Added by Andriy Lesyuk over 5 years ago

.git extension for Git external URL (#2290), removed login/password hiding

Revision 138 (diff)
Added by Andriy Lesyuk over 5 years ago

Sequent repository names fix (#2290)

History

#1 Updated by Andriy Lesyuk over 5 years ago

  • Status changed from New to Under Verification
  • Target version set to 0.5.0b

Wow! Thanks, Elektritter!

I will review them.

#2 Updated by Elektritter Messinger over 5 years ago

And of course I found a small bug inside my patches after upload: the js generating the url entry does not insert “file://” in front of subversion urls and since a while this is required in repository model when using subversion.

(0013 'cause I had a commit mistake and had to revert the commit, so 0012 was the revert of 0011)

#3 Updated by Andriy Lesyuk over 5 years ago

So, the review results (will update this note with new ones):

  • 0001 – I aim to drop patched files in future (_form.html.erb is one of them), when it becomes possible.
    This patch adds a new reason to keep them, so I can’t include it.
  • 0002 – I like the current position of the button, so not applying it.
    However, your patch shows where is the bug #2238! So, it helped me. Thanks!
  • 0003 – Should we hide login/password, when local repositories are disabled? Why?
    Not including it for now (while used to slightly modify it in r136).
  • 0004 – Refactored your patch in r137. Thanks a lot!
  • 0005 – Not including it as well for the same reason.
  • 0006 – Applied refactored patch in r138. Thanks!
  • 0007 – Same as 0002 – not applying.
  • 0008 – Same as 0002 – not applying.

Thanks for sharing patches!

#4 Updated by Andriy Lesyuk over 5 years ago

  • Target version deleted (0.5.0b)
  • % Done changed from 0 to 70

#5 Updated by Andriy Lesyuk almost 3 years ago

  • Target version set to 0.5.1

Also available in: Atom PDF

Terms of use | Privacy policy