I'm looking for a part-time remote job.

Hire me

I'm the author of:

Mastering Redmine is a comprehensive guide with tips, tricks and best practices, and an easy-to-learn structure.

Check the book's project or

Buy the book

Social pages of the book:

By buying this book you also donate to Redmine (see this page).

Follow me:

Bug #2256

Various problem using trunk on Redmine 2.3.3

Added by Martin Corino over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Major
Assignee:
Andriy Lesyuk
Category:
-
Target version:
1.0.0b
Start date:
15 Oct 2013
Due date:
19 Oct 2013
% Done:

100%

Redmine version:
2.3.3
External issue:

Description

I tried the trunk version on a new Redmine 2.3.3 installation and ran into the following problems:

  1. the WikiMacro.register_all! call at the end of init.rb causes an exception when trying to run rake redmine:plugins:migrate when the new wiki_macros migration has not been run before (and therefor the table for the model does not exist yet)
  2. the missing support for the (new?) text argument for wiki macros caused the macro replacement code to crash
  3. the exec_macro_with_custom hook in wiking_macros_definitions_patch.rb does not get triggered when a WikiNG custom macro has not been loaded yet (since I removed WikiMacro.register_all! to prevent the problems with the migration) because the wiki formatting code calls Redmine::WikiFormatting::Macros::Definitions#macro_exists? before calling exec_macro.

I created a patch that solved all my problems which you can find attached.
The patch does not take different Redmine version into account.

patch.diff View - change diff (2.98 KB) Martin Corino, 15 Oct 2013 14:10

History

#1 Updated by Andriy Lesyuk over 10 years ago

Thank you very much, Martin! In fact, the SVN version is not intended to be functioning yet!.. It’s the version in progress. Anyway your findings will definitely help me! Thanks!

P.S. For a stable WikiNG use the file: wiking_0.0.4.tar.bz2.

#2 Updated by Andriy Lesyuk over 10 years ago

  • Status changed from New to Open
  • Assignee set to Andriy Lesyuk
  • Target version set to 1.0.0b

#3 Updated by Martin Corino over 10 years ago

Andriy Lesyuk wrote:

Thank you very much, Martin! In fact, the SVN version is not intended to be functioning yet!.. It’s the version in progress. Anyway your findings will definitely help me! Thanks!

P.S. For a stable WikiNG use the file: wiking_0.0.4.tar.bz2.

Yes, I was aware of that, but I was very interested to see the custom macro functionality so I just decided to give it a try. For me it works good enough for now.
I have your repository cloned in Git so I can easily merge your changes as they come.

#4 Updated by Andriy Lesyuk over 10 years ago

  • Due date set to 19 Oct 2013
  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Your fixes helped, Martin. Thank you, again!

Also available in: Atom PDF

Terms of use | Privacy policy