I'm looking for a part-time remote job.

Hire me

I'm the author of:

Mastering Redmine is a comprehensive guide with tips, tricks and best practices, and an easy-to-learn structure.

Check the book's project or

Buy the book

Social pages of the book:

By buying this book you also donate to Redmine (see this page).

Follow me:

Bug #2208

Enable contact form button on wrong tab

Added by Johnny Tide over 11 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Andriy Lesyuk
Target version:
0.1.1
Start date:
05 Aug 2013
Due date:
31 May 2014
% Done:

100%

Redmine version:
External issue:

Description

I have a plugin installed that adds an extra tab to admin>>users>>edit page.
The problem is with contact_form/assets/javascripts/contact_jquery.js/function fix_enable_contact_form_position().
Since I have an extra tab with a box tabular section the function is adding the setting there.

Is there a way to have it find the last box tabular on the general tab and not the last one in the form?

other_plugins_problem.png View (11.6 KB) Johnny Tide, 05 Aug 2013 04:01

contact_form_redmine_2.4 (1.42 KB) Johnny Tide, 06 Aug 2013 06:05

contact_form_redmine_2.4_fixed (1.45 KB) Johnny Tide, 06 Aug 2013 17:09

Related issues

Related to Contact Form - Bug #2207: Internet Explorer render issue Closed 05 Aug 2013 31 May 2014

Associated revisions

Revision 62 (diff)
Added by Andriy Lesyuk over 10 years ago

Fixed “Enabled contact form” (#2207 and #2208)

History

#1 Updated by Johnny Tide over 11 years ago

I added an issue at the Redmine site that will allow you and others to add settings to or after the Preferences section in “My account” or “Users>>Edit”.

#14614

#2 Updated by Johnny Tide over 11 years ago

The view hooks I requested in #14614 have been added in r12085. This will help me in the plugin I am working on and I hope it helps you too.

#3 Updated by Johnny Tide over 11 years ago

I wrote a patch against your current trunk for use when Redmine goes to 2.4. It will use your current code for Redmine versions under 2.4 and the new view hooks for versions of Redmine greater than or equal to 2.4.

This has fixed my issues with using Contact Form along with Redmine Local Avatars. Thanks again for your great Redmine contributions!

#4 Updated by Johnny Tide over 11 years ago

Just realized I forgot to delete the old part in the patch I posted above. Also, the check will not work after they release 3.0. I will upload a new patch a little bit later.

#5 Updated by Johnny Tide over 11 years ago

Here is the corrected version. I hope this one is correct.

#6 Updated by Andriy Lesyuk about 11 years ago

  • Target version set to 0.1.1

#7 Updated by Andriy Lesyuk about 11 years ago

  • Status changed from New to Open

#8 Updated by Andriy Lesyuk over 10 years ago

  • Due date set to 31 May 2014
  • Status changed from Open to Closed
  • Assignee set to Andriy Lesyuk
  • % Done changed from 0 to 100

Thank you very much, Johnny!

Also available in: Atom PDF

Terms of use | Privacy policy