Contact form for Redmine 2.5.x
Contact form for Redmine 2.5.xThere were little modifications needed for Contact Form to work under Redmine 2.5.x, much more modifications were needed to fix the position of the "Enable contact form" checkbox in user profiles...
To be honest, I never personally noticed the incorrect position of the “Enable contact form” checkbox as described in #2207 and #2208, but I could understand the reason, why this could happen... Normally, I use Redmine hooks to add some elements to a form, but in the case of the user profile such suitable hooks were not available. So, I was forced to use an alternative approach – to add elements using an unsuitable hook and then to move them to the correct position using JavaScript. But, accordingly to some users, this approach used to fail...
Thus, it failed for Johnny Tide... But, Johnny not only investigated the bug and suggested the solution (see #2207), but also requested new hooks for user profiles on Redmine (see issue #14614)! After Redmine guys have complied Johnny’s request he also updated the Contact Form plugin and shared the patch! Thank you, Johnny! Great job! You literally made this release to happen!
Notice, that as a result of the described fix and as a result of switching to Redmine’s hooks, the position of the “Enable contact form” checkbox has changed in 0.1.1 (it was moved to the bottom):
Not much was done for the Contact Form plugin besides Johnny’s work... Thus, I also fixed an issues in rendering the text template for the contact email, which I caught under Redmine 2.5.x.
Comments