I'm looking for a part-time remote job.

Hire me


I'm the author of:

Mastering Redmine is a comprehensive guide with tips, tricks and best practices, and an easy-to-learn structure.

Check the book's project or

Buy the book

Social pages of the book:

By buying this book you also donate to Redmine (see this page).


Follow me:

Bug #1814

Overlapping 'inline code' lines

Added by Ivan Cenov about 9 years ago. Updated almost 9 years ago.

Status:
Won't Fix
Priority:
Normal
Assignee:
Target version:
Start date:
01 Aug 2011
Due date:
26 Sep 2011
% Done:

100%

Redmine version:

Description

Here is the example:

redmine_code.jpg View (12.1 KB) Ivan Cenov, 01 Aug 2011 10:59

co_19px.jpg View (44.5 KB) Ivan Cenov, 19 Sep 2011 11:53

co_20px.jpg View (48.3 KB) Ivan Cenov, 19 Sep 2011 11:53

co_ie.jpg View (103 KB) Ivan Cenov, 19 Sep 2011 11:53

Associated revisions

Revision 9 (diff)
Added by Andriy Lesyuk about 9 years ago

Partially fixed #1813 and fixed #1814

Revision 10 (diff)
Added by Andriy Lesyuk about 9 years ago

Added another rule for #1814

History

#1 Updated by Andriy Lesyuk about 9 years ago

  • Status changed from New to Incomplete
  • Assignee set to Andriy Lesyuk

This is visual only. There are no “boxes” - they are rendered around text. Can be fixed by adding additional space between lines but I’m not sure if this is a good workaround...

#2 Updated by Andriy Lesyuk about 9 years ago

Looks like can be fixed with:

code {
    line-height: 18px;
}

Now sure how this affects other elements... Need to test.

Could you please check?

#3 Updated by Andriy Lesyuk about 9 years ago

  • % Done changed from 0 to 50

#4 Updated by Andriy Lesyuk about 9 years ago

For Chrome seems it should be 20px

#5 Updated by Ivan Cenov about 9 years ago

Where to put this? I am not fluent in CSS...

code {
     line-height: 18px;
}
There is 'code’ in application.css and it is
code {
    padding: 1px 2px;
    -moz-border-radius: 2px;
    border-radius: 2px;
    -moz-box-shadow: 1px 1px 2px #b4b4b4;
    box-shadow: 1px 1px 2px #b4b4b4;
    background-color: #fff;
    border: 1px solid #b4b4b4;
}
Inside it?

#6 Updated by Ivan Cenov about 9 years ago

here are the results:

and

and in IE 8.0:

It seems this is the solution. I tested on Windows XP SP3 + Firefox 6.0.2 and Internet Explorer 8.0

#7 Updated by Andriy Lesyuk about 9 years ago

  • Status changed from Incomplete to Open
  • Target version set to 0.02
  • % Done changed from 50 to 80

Thanks! Will include it then in 0.02...

#8 Updated by Andriy Lesyuk about 9 years ago

  • Status changed from Open to Under Verification
  • % Done changed from 80 to 90

Changes are in SVN... Testing them on this site.

#9 Updated by Andriy Lesyuk almost 9 years ago

  • Due date set to 26 Sep 2011
  • Status changed from Under Verification to Won't Fix
  • % Done changed from 90 to 100

I believe it does works!

Also available in: Atom PDF

Terms of use | Privacy policy